Change in vdsm[master]: Introduce a singleton decorator

shuming at linux.vnet.ibm.com shuming at linux.vnet.ibm.com
Tue May 29 14:38:10 UTC 2012


Shu Ming has posted comments on this change.

Change subject: Introduce a singleton decorator
......................................................................


Patch Set 2:

Saggi, why singleton is a evil to you? Because of the code readability or bug prone?

>Also you should use a class decorator if you want the >decorator to have sate instead of pushing things to the
                    ^ state?
 >protected state of the wrapped class.

--
To view, visit http://gerrit.ovirt.org/4839
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I17c1b7be60a50cdaa731ee88f29d2017ea6c3f2b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list