Change in vdsm[master]: Remove the parameter of clientIF instance from API

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Tue May 29 02:16:56 UTC 2012


Mark Wu has posted comments on this change.

Change subject: Remove the parameter of clientIF instance from API
......................................................................


Patch Set 7: (1 inline comment)

....................................................
File vdsm/API.py
Line 54:         self._cif = clientIF()
Dan,
The newly-defined singleton decorator doesn't add a method getInstance to the decorated class. It overrides the behavior of constructor. So to get the single instance of clientIF, I just need use clientIF().  If  you think using clientIF.getInstance() is more    clear to indicate the class is a singleton, I will change the decorator patch.

--
To view, visit http://gerrit.ovirt.org/4603
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9dd1c555d066c20bd13da6db569fa709772c74ef
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list