Change in vdsm[master]: BZ#788640 - Remove subChainSizeCalc() and getSubChain(). Rem...

abaron at redhat.com abaron at redhat.com
Mon May 28 09:26:06 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: BZ#788640 - Remove subChainSizeCalc() and getSubChain(). Remove getAllChildrenList().
......................................................................


Patch Set 17: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/image.py
Line 1036:         return min(accumulatedChainSize, imageApparentSize) * 1.1, chain
This function should just return accumulatedChainSize.
It is up to the calling function to determine the usage and add the extra 10%, it has nothing to do with the "actual" size calculation

--
To view, visit http://gerrit.ovirt.org/3468
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iffbbf71269eddb53c032c381d10e20b771c47c6b
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list