Change in vdsm[master]: Change oop to be a new process instead of a fork

fsimonce at redhat.com fsimonce at redhat.com
Fri May 25 15:02:08 UTC 2012


Federico Simoncelli has posted comments on this change.

Change subject: Change oop to be a new process instead of a fork
......................................................................


Patch Set 2: Looks good to me, but someone else must approve

(3 inline comments)

Minor questions. I also have an host running this change and looks fine.

....................................................
File vdsm/storage/iscsi.py
Line 131:             iscsiadm.node_update(iface.name, portalStr, targetName, "node.startup", "manual")
Unrelated change?

....................................................
File vdsm/storage/remoteFileHandler.py
Line 29: import pickle
Does this need to be somewhat backward compatible or can we move to something faster like cPickle protocol 2? (any problem with binary data?)

Line 43: if __name__ != "__main__":
Is this a workaround for the tests? Could you add a comment explaining why we need it and when we are supposed to remove it (eg: when the git repo structure will be fixed, etc...). Even better if we can get rid of it now.

--
To view, visit http://gerrit.ovirt.org/4318
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65e58030e31fe54b0e79c2f2a415d081f890d41f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list