Change in vdsm[master]: BZ#821867: Do not append comments to config values

fsimonce at redhat.com fsimonce at redhat.com
Fri May 25 07:54:57 UTC 2012


Federico Simoncelli has posted comments on this change.

Change subject: BZ#821867: Do not append comments to config values
......................................................................


Patch Set 4: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/vdsmd.init.in
Line 271:     local start_conf_section="## beginning of configuration section"
I think we should cite vdsm here (since it's what we'll be looking for at line 276). It means that we should reorganize a little bit the variables, probably something like:

 local by_vdsm="by vdsm"
 local by_vdsm_vers="4.9.6"
 local start_conf_section="## beginning of configuration section ${by_vdsm}"
 [...]
 echo "${start_conf_section}-${by_vdsm_vers}" >> "${arg}"

--
To view, visit http://gerrit.ovirt.org/4716
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01840754844fbcd4d3f44bd16e0627015a59af83
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib at redhat.com>


More information about the vdsm-patches mailing list