Change in vdsm[master]: dumpStorageTable: fix path to ovf files

danken at redhat.com danken at redhat.com
Fri May 25 07:19:51 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: dumpStorageTable: fix path to ovf files
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(3 inline comments)

....................................................
Commit Message
Line 7: dumpStorageTable: fix path to ovf files
I beg your pardon, but I do not notice where is the fix.

at a cursory look, changes seemed algebraic cleanups to me. I know that I'm missing something - please point it out to me (preferably in the commit message).

....................................................
File vdsm/dumpStorageTable.py.in
Line 26: MASTERSD_PATH = 'mastersd/master/vms'
actually, it is MASTERSD_VM_PATH, but I do not really mind.

Line 41:             vm_images_links = os.listdir(os.path.join(DC, pool, MASTERSD_PATH, vmUUID))
while at it, it would be nicer if you break long lines.

--
To view, visit http://gerrit.ovirt.org/4804
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99262e5d0ace5236ef97606a630b2bff1bd8b4c8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Derrick Ornelas <dornelas at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list