Change in vdsm[master]: Fix multiple commands with same name in different vdsm-tool ...

agl at us.ibm.com agl at us.ibm.com
Thu May 24 21:54:58 UTC 2012


Adam Litke has posted comments on this change.

Change subject: Fix multiple commands with same name in different vdsm-tool modules
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

Patch looks good.  I am just suggesting a rewording of some text.

....................................................
File vdsm-tool/vdsm-tool
Line 81:                 continue
If you don't mind I will suggest a slight rewording of the text:

Warning: the command '%s' in module '%s' is being ignored because a command with the same name has already been registered by module '%s'

--
To view, visit http://gerrit.ovirt.org/4645
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a289a202e0efcb7f2948b6200ea39552164f5b6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <wenyi at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list