Change in vdsm[master]: Remove the parameter of clientIF instance from API
danken at redhat.com
danken at redhat.com
Thu May 24 18:48:24 UTC 2012
Dan Kenigsberg has posted comments on this change.
Change subject: Remove the parameter of clientIF instance from API
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
Seems better; still, I do not see the grand benefit of this over making clientIF.clientIF object a clear singleton in its own module.
For elegance, I'd prefer if you find a way to allow two such objects in the process. But currently, creating a second clientIF while vdsm is running is going to cause havoc with all existing API objects.
....................................................
File vdsm/API.py
Line 718: class Image(apiBase):
pylakes would have cried.
--
To view, visit http://gerrit.ovirt.org/4603
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dd1c555d066c20bd13da6db569fa709772c74ef
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>
More information about the vdsm-patches
mailing list