Change in vdsm[master]: MOM Integration

Xu He Jie xuhj at linux.vnet.ibm.com
Thu May 24 16:41:57 UTC 2012


Xu He Jie has posted comments on this change.

Change subject: MOM Integration
......................................................................


Patch Set 9: I would prefer that you didn't submit this

(5 inline comments)

....................................................
File vdsm/ksm.py
Line 30:         momBase.__init__(self, log, self.run, 'KsmMonitor')
I know this work. I guess only use one way, overriding run() method or set target, will be more clean

Line 39:                 self.start()
It looks can't start thread at base class. But move start out of __init__, and just overriding start() method will be clean. is right?

....................................................
File vdsm/vdsMOM.py
Line 25: class momBase(threading.Thread):
the name should be MomBase

Line 45: class vdsMOM(momBase):
same with above

Line 48:         import mom
why not import mom at top of file

--
To view, visit http://gerrit.ovirt.org/2367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I61e68f72e9115a913d5bc0f4903b906b0d0cce2f
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list