Change in vdsm[master]: Make scratchpad/before_vm_start.py compliant to pep8

mars at linux.vnet.ibm.com mars at linux.vnet.ibm.com
Thu May 24 08:34:05 UTC 2012


Bing Bu Cao has posted comments on this change.

Change subject: Make scratchpad/before_vm_start.py compliant to pep8
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File Makefile.am
Line 47: 	vdsm_hooks/scratchpad/before_vm_start.py \
Sort the list

....................................................
File vdsm_hooks/scratchpad/before_vm_start.py
Line 119:                                      (must start with /)\n' % path)
Why not keep using double ' ' instead of \ ?

--
To view, visit http://gerrit.ovirt.org/4578
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie160109de403b45bd1ca78faecf8140caadc2216
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <wenyi at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Bing Bu Cao <mars at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list