Change in vdsm[master]: Adding KSM pages_shared and pages_sharing stats.

danken at redhat.com danken at redhat.com
Wed May 23 20:01:45 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Adding KSM pages_shared and pages_sharing stats.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

still, the commit message better declare which are the newly-reported bits of information, and what they are good for.

....................................................
File vdsm/API.py
Line 1336:     def _ksmShared():
hiding these funcitons in ksm.py seemed like a good idea to me.

Line 1339:             ksmshared = int(file('/sys/kernel/mm/ksm/pages_shared').read()) * PAGE_SIZE_BYTES
please keep new code with shorter lines.

--
To view, visit http://gerrit.ovirt.org/4700
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I185eec12f6881f9bb266f8c06a1061263e16e999
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list