Change in vdsm[master]: Configure libvirt to use sanlock

fsimonce at redhat.com fsimonce at redhat.com
Wed May 23 07:49:03 UTC 2012


Federico Simoncelli has posted comments on this change.

Change subject: Configure libvirt to use sanlock
......................................................................


Patch Set 7: (1 inline comment)

....................................................
File vdsm/vdsmd.init.in
Line 270:     local by_vdsm_vers="${by_vdsm}-4.9.6"
Yes, we don't want to update the libvirt configuration (and restart the service) every time we change PACKAGE_VERSION (even if it's rare), and more importantly we might need to change this more frequently than PACKAGE_VERSION (eg: 4.9.6-1, etc...). So it's something almost unrelated to PACKAGE_VERSION, in fact we can use any other string if it's confusing. Anyway I thought that using the version where a change was made looked reasonable to me.

--
To view, visit http://gerrit.ovirt.org/4210
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I457b537083942b7ef3d3b8c5df6d60accdbd75da
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Wenchao Xia <xiawenc at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list