Change in vdsm[master]: Adding KSM pages_shared and pages_sharing stats (in MBytes).

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Wed May 23 05:53:01 UTC 2012


Mark Wu has posted comments on this change.

Change subject: Adding KSM pages_shared and pages_sharing stats (in MBytes).
......................................................................


Patch Set 1: I would prefer that you didn't submit this

This patch is helpful for users to know how much memory is saved by KSM and it's more accurate than the existing 'memShared'.  I think we needn't wait for the MOM integration patch to consider this one. Because, the MOM integration patch doesn't change how ksmMonitor works. It just moves KSM tuning and stats reporting function to MOM and falls back to ksmMonitor if MOM is not available. So this patch doesn't have any dependency on the MOM integration patch. 

But the patch itself, it seems that it can't reflect actual KSM stats in time, because the result is retrieved when  adjust() is called, not the time getStats() is invoked. Perhaps there's a big difference of them because of the KSM work.

--
To view, visit http://gerrit.ovirt.org/4614
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5948b4eb8925fab1071a3b670deff6de2f4f4fb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list