Change in vdsm[master]: Added gluster cli support in supervdsm.

ewoud at kohlvanwijngaarden.nl ewoud at kohlvanwijngaarden.nl
Tue May 22 12:12:22 UTC 2012


Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: Added gluster cli support in supervdsm.
......................................................................


Patch Set 22: (1 inline comment)

....................................................
File vdsm/gluster/hostname.py
Line 38:     rc, out, err = utils.execCmd([_hostNameCommandPath.cmd, '--fqdn'])
socket.getfqdn() does return the fqdn. It will call socket.gethostbyaddr(socket.gethostname()) and then go through the hostname and all aliases. Then picks the first with a dot in it and fall back to the hostname.

For all well configured networks this I think this is the correct result, but I don't know how it behaves for some of the weirder setups people might have. man 2 uname is rather vague about how it determines the name.

I would prefer pure python over calling system binaries, but would be interested to know if Federico thinks the same.

--
To view, visit http://gerrit.ovirt.org/2797
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2faa261a3c44cf84af14102bdf6479287435793b
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>


More information about the vdsm-patches mailing list