Change in vdsm[master]: Added gluster cli support in supervdsm.

barumuga at redhat.com barumuga at redhat.com
Tue May 22 10:34:23 UTC 2012


Bala.FA has posted comments on this change.

Change subject: Added gluster cli support in supervdsm.
......................................................................


Patch Set 22: (3 inline comments)

....................................................
File vdsm/gluster/cli.py
Line 33: _EXT_GLUSTER_CLI = _glusterCommandPath.cmd
Fix is on the way

....................................................
File vdsm/gluster/hostname.py
Line 38:     rc, out, err = utils.execCmd([_hostNameCommandPath.cmd, '--fqdn'])
'hostname --fqdn' does more according to the man page.  I don't have any idea to implement python equivalent now.

Line 38:     rc, out, err = utils.execCmd([_hostNameCommandPath.cmd, '--fqdn'])
Yes.  But 'strace hostname --fqdn' does more.

--
To view, visit http://gerrit.ovirt.org/2797
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2faa261a3c44cf84af14102bdf6479287435793b
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>


More information about the vdsm-patches mailing list