Change in vdsm[master]: Support unicode args in betterPopen

danken at redhat.com danken at redhat.com
Mon May 21 22:22:28 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Support unicode args in betterPopen
......................................................................


Patch Set 3: Looks good to me, approved

(1 inline comment)

....................................................
File vdsm/betterPopen/createprocess.c
Line 145:                          Py_FileSystemDefaultEncoding,
for the record: I prefer minimum surprises, and a drop-in replacement of subprocess.Peopen. If you want to implement some behavior differently - you can still document and explain your choice.

--
To view, visit http://gerrit.ovirt.org/4414
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I194e75bfca30bcbc6d7fb0f2a24b30eb6162cddb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Wenchao Xia <xiawenc at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list