Change in vdsm[master]: Remove the parameter of clientIF instance from API

danken at redhat.com danken at redhat.com
Mon May 21 21:45:27 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Remove the parameter of clientIF instance from API
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

cursory review

....................................................
File vdsm/API.py
Line 64:     def addClasses(self, cif):
python allows this, but wouldn't it be cleaner if these classes inherit from a base class that provides a reference to the cif singleton? I do not see the benefit of adding an API singleton over asserting the cif is one.

Line 91:         elif cls._instance == None:
this is raceful.

--
To view, visit http://gerrit.ovirt.org/4603
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9dd1c555d066c20bd13da6db569fa709772c74ef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list