Change in vdsm[master]: Tunnel errors from child to parent in betterPopen

fsimonce at redhat.com fsimonce at redhat.com
Mon May 21 18:36:08 UTC 2012


Federico Simoncelli has posted comments on this change.

Change subject: Tunnel errors from child to parent in betterPopen
......................................................................


Patch Set 3: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/betterPopen/createprocess.c
Line 266:     if (read(errnofd[0], &childErrno, sizeof(int)) == sizeof(int)) {
Ah ok great I thought so, but I believed we didn't mind where the error was coming from.

--
To view, visit http://gerrit.ovirt.org/4413
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d4a132317e9cf0843671460a0876f615760731d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Wenchao Xia <xiawenc at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list