Change in vdsm[master]: Fixing pep8 in vdsm/storage/fileVolume.py

mars at linux.vnet.ibm.com mars at linux.vnet.ibm.com
Mon May 21 09:02:38 UTC 2012


Bing Bu Cao has posted comments on this change.

Change subject: Fixing pep8 in vdsm/storage/fileVolume.py
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm/storage/fileVolume.py
Line 422:                         getImage() == imgUUID):
I think both way are OK.
Put "." at head of the line make the code more neat.
But put "." at the trail of the line,the code will be consistent with lines end with  "," :

pattern = os.path.join(repoPath, sdUUID, sd.DOMAIN_IMAGES,
415	                               imgUUID, "*.meta")

--
To view, visit http://gerrit.ovirt.org/4541
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e1ce2aef9ac4be974529ecaf76d5dc5a578d92d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bing Bu Cao <mars at linux.vnet.ibm.com>
Gerrit-Reviewer: Bing Bu Cao <mars at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list