Change in vdsm[master]: Title: fix some code style consist with pep8

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Fri May 18 01:17:41 UTC 2012


Zhou Zheng Sheng has posted comments on this change.

Change subject: Title: fix some code style consist with pep8
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(9 inline comments)

There are some minor problems in your changes, please correct them.

....................................................
File vdsm/storage/storage_exception.py
Line 862:                         "by this version of VDSM" % version)
Miss a space after "unsupported". It should be
("...unsupported "
 "by..." % version)

Line 871:                         (sdUUID, expVer, curVer))
Same as line 861.

Line 879:                         "in procces is unsupported (pool: `%s`)" % (spUUID,))
Same as line 861.

Line 894:                         "msd %s version (%d)" %
Same as line 861.

Line 972: 
I suggest:
("%s: %s ..." %
 (self.message ...))
Let the second line align with the first element in parentheses in the upper line.

Line 1184:                "in the registered with this VDSM")
Same as line 861.

Line 1321:                       "newsize=%s" % (vgname, lvname, newsize))
Same as line 861.

Line 1494:                       "mdafree=%s" % (vgname, mdasize, mdafree))
Same as line 861.

Line 1507:                       "mdafree=%s" % (vgname, mdasize, mdafree))
Same as line 861.

--
To view, visit http://gerrit.ovirt.org/4500
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50cf61d9b7815cbdd5571930e3f9be59183a83f4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Changming Bai <baichm at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list