Change in vdsm[master]: Fix pep8 problems

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Thu May 17 01:30:23 UTC 2012


Zhou Zheng Sheng has posted comments on this change.

Change subject: Fix pep8 problems
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(7 inline comments)

....................................................
File vdsm_hooks/scratchpad/after_vm_destroy.py
Line 17
I suggest we write code like this:
sys.stderr.write('scratchpad after_vm_destroy: '
                 'cannot find image file %s\n' % arr[1])

Line 20
Same as line 16.

....................................................
File vdsm_hooks/scratchpad/before_vm_migrate_source.py
Line 8
Same as vdsm_hooks/scratchpad/after_vm_destroy.py line 16.

....................................................
File vdsm_hooks/scratchpad/before_vm_start.py
Line 24
I think let '"M" (mega...' and 'T (tera...' align with 'Optional' is better.

Line 100
Please refer to comments on vdsm_hooks/scratchpad/after_vm_destroy.py line 16.

Line 108
Please refer to comments on vdsm_hooks/scratchpad/after_vm_destroy.py line 16.

Line 116
Please refer to comments on vdsm_hooks/scratchpad/after_vm_destroy.py line 16.

--
To view, visit http://gerrit.ovirt.org/4453
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I437f22254f318ae4394ecfd4fad519fcb2254904
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <wenyi at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list