Change in vdsm[master]: Added gluster cli support in supervdsm.
ewoud at kohlvanwijngaarden.nl
ewoud at kohlvanwijngaarden.nl
Mon May 21 14:14:23 UTC 2012
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Added gluster cli support in supervdsm.
......................................................................
Patch Set 22: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File vdsm/gluster/hostname.py
Line 38: rc, out, err = utils.execCmd([_hostNameCommandPath.cmd, '--fqdn'])
If I compare `man hostname` to `pydoc socket.fqdn` it's gethostbyname vs gethostbyaddr. I think that's equal, but not 100% sure. I get that you want to finish this and this works so I wouldn't mind if you kept it as-is.
--
To view, visit http://gerrit.ovirt.org/2797
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2faa261a3c44cf84af14102bdf6479287435793b
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
More information about the vdsm-patches
mailing list