Change in vdsm[master]: PEP8 style cleanups for netinfo.py & configNetwork.py

danken at redhat.com danken at redhat.com
Mon May 21 08:00:17 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: PEP8 style cleanups for netinfo.py & configNetwork.py
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(3 inline comments)

....................................................
File Makefile.am
Line 48:         vdsm/netinfo.py \
tab

Line 56:         vdsm/rest/Controller.py
keep as tab

....................................................
File vdsm/netinfo.py
Line 430:         return [netname for (netname, net) in networks().iteritems() \
no need for this trailing backslash

--
To view, visit http://gerrit.ovirt.org/4570
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7bba9daeb3f726cb23ebcd2c4c5fc2bd6e3c1301
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list