Change in vdsm[master]: change the code style of before_vm_start.py for PEP8 complia...

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Mon May 21 06:40:07 UTC 2012


Zhou Zheng Sheng has posted comments on this change.

Change subject: change the code style of before_vm_start.py for PEP8 compliance
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File vdsm_hooks/sriov/before_vm_start.py
Line 39:                                                        firstChild.nodeValue))
How about

    slot = hex(int(
                devXml.getElementsByTagName('slot')[0]
                      .firstChild.nodeValue))

Line 41:                                                        firstChild.nodeValue))
How about

    function = hex(int(
                    devXml.getElementsByTagName('function')[0]
                          .firstChild.nodeValue))

--
To view, visit http://gerrit.ovirt.org/4552
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15551c9a756b3c1e3f1ef6558623c1008a5b8f47
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list