Change in vdsm[master]: Fixing pep8 in vdsm/storage/fileVolume.py

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Mon May 21 06:15:39 UTC 2012


Zhou Zheng Sheng has posted comments on this change.

Change subject: Fixing pep8 in vdsm/storage/fileVolume.py
......................................................................


Patch Set 1: (4 inline comments)

I think some of the long lines can be wrapped in a more readable way.

....................................................
File vdsm/storage/fileVolume.py
Line 220:         # Remove all previous rollbacks for 'halfbaked' volume and
If it is a blank line in a block comment, add a "#" for the blank line looks nicer.

Line 300:         src = self._getMetaVolumePath()
How about:

self.log.debug("share  meta of %s to %s hard %s" %
               (self.volUUID, dst_image_dir, hard))

Line 303:         if self.oop.fileUtils.pathExists(dst):
I like

dst = self._getMetaVolumePath(
                os.path.join(dst_image_dir, self.volUUID))

What do you think?

Line 426:                 volList.append(volid)
I suggest:

            if (sdCache.produce(sdUUID)
                       .produceVolume(imgUUID, volid)
                       .getImage() == imgUUID):

--
To view, visit http://gerrit.ovirt.org/4541
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e1ce2aef9ac4be974529ecaf76d5dc5a578d92d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bing Bu Cao <mars at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list