Change in vdsm[master]: Remove unnecesary preparePaths.

ewarszaw at redhat.com ewarszaw at redhat.com
Sun May 20 06:03:30 UTC 2012


Eduardo has posted comments on this change.

Change subject: Remove unnecesary preparePaths.
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/clientIF.py
Line 985
Since the VM's are up and running, there is no need for any real storage operation.
All is already done.
We only need to update the VM register due to the unfortunate fact that we are using the conf instead live info from the host.
This prepare call should not be here since all is already prepared. Additional future things should have proper calls, but I feel that for all cases this will not related to storage.
The vmstats issue is another proof that stats is not related to VM life nor storage management.

--
To view, visit http://gerrit.ovirt.org/786
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35890d36227633ca147387d670c152b9be357e50
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list