Change in vdsm[master]: tests: Package up tests

danken at redhat.com danken at redhat.com
Sat May 19 07:12:39 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: tests: Package up tests
......................................................................


Patch Set 4: Looks good to me, but someone else must approve

(1 inline comment)

That's somewhat different from Wenchao's take on list, so I'd like to see that he's on board. I'm happy with this and the following patch.

....................................................
File tests/run_tests.sh.in
Line 2: prefix="@prefix@"
that's confusing, since no $prefix is explicitly used here.

(but I have no idea for improvement atm)

--
To view, visit http://gerrit.ovirt.org/4451
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I40a5d97b8cffcbaa465cab61aa890ff2520a4179
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Wenchao Xia <xiawenc at linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list