Change in vdsm[master]: Added gluster cli support in supervdsm.

danken at redhat.com danken at redhat.com
Fri May 18 19:34:17 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Added gluster cli support in supervdsm.
......................................................................


Patch Set 19: I would prefer that you didn't submit this

(1 inline comment)

I'm fine if you promise to fix this in a later patch...

....................................................
File vdsm/gluster/hostname.py
Line 31:         return ''
I missed this completely - please do not swallow the error in such a low level. the proper thing in this binding level is to raise an exception, that can be swallowed by _getGlusterHostName

--
To view, visit http://gerrit.ovirt.org/2797
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2faa261a3c44cf84af14102bdf6479287435793b
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>


More information about the vdsm-patches mailing list