Change in vdsm[master]: Change to use WatchedFileHandler instead of FileHandler in l...

danken at redhat.com danken at redhat.com
Fri May 18 11:57:07 UTC 2012


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Change to use WatchedFileHandler instead of FileHandler in logger.conf
......................................................................


Change to use WatchedFileHandler instead of FileHandler in logger.conf

We find that no new log message appears in log file after manually changing
the vdsm log when vdsm is running. We have to restart vdsm to get logging
work again. It could happen when people try to add some markers to pinpoint
the related messages during toubleshooting. It's caused by the log file gets
associated with a new inode after the manual change. To make logging survive
the change, use WatchedFileHandler instead of FileHandler.

In addition, WatchedFileHandler was provided specially for the external
log rotate tools. It can notice that the log file change performed by
logrotate, so we don't need to have the option 'copytruncate' in
vdsm-logrotate.conf any more.

Change-Id: Iaf1cd7f3c7d568b8351eaa3ce262532caec94c7e
Reported-by: Changming Bai <baichm at linux.vnet.ibm.com>
Signed-off-by: Mark Wu <wudxw at linux.vnet.ibm.com>
---
M vdsm/logger.conf.in
M vdsm/vdsm-logrotate.conf.in
2 files changed, 2 insertions(+), 3 deletions(-)

Approvals:
  Changming Bai: Verified
  Dan Kenigsberg: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/4463
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf1cd7f3c7d568b8351eaa3ce262532caec94c7e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Changming Bai <baichm at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list