Change in vdsm[master]: tests: Package up tests

ewoud at kohlvanwijngaarden.nl ewoud at kohlvanwijngaarden.nl
Fri May 18 09:30:22 UTC 2012


Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: tests: Package up tests
......................................................................


Patch Set 3: Looks good to me, but someone else must approve

(1 inline comment)

Looks good, minor comment inline.

....................................................
File tests/run_tests.sh.in
Line 2: prefix="@prefix@"
Why is this prefix variable needed? I don't see you using it and it's not exported.

--
To view, visit http://gerrit.ovirt.org/4451
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I40a5d97b8cffcbaa465cab61aa890ff2520a4179
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Wenchao Xia <xiawenc at linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list