Change in vdsm[master]: change the code style of SecureXMLRPCServer.py for PEP8 comp...

shaohef at linux.vnet.ibm.com shaohef at linux.vnet.ibm.com
Fri May 18 06:16:04 UTC 2012


ShaoHe Feng has posted comments on this change.

Change subject: change the code style of SecureXMLRPCServer.py for PEP8 compliance
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/SecureXMLRPCServer.py
Line 49:         """
http://www.python.org/dev/peps/pep-0257/#multi-line-docstrings
it say:
The summary line may be on the same line as the opening quotes or on the next line.

And we have test buy pydoc, the two docstrings are equivalent.
so I think a newline is ok.

but I should keep the same style in one file, I will remove this newline.

--
To view, visit http://gerrit.ovirt.org/4518
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41be7b4190b2adf472c82dfc28e46a557dce7b12
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list