Change in vdsm[master]: Added gluster cli support in supervdsm.

danken at redhat.com danken at redhat.com
Thu May 17 18:49:32 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Added gluster cli support in supervdsm.
......................................................................


Patch Set 17: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/gluster/cli.py
Line 242: def volumeReset(volumeName, option='', force=False):
very very minor: since we have None in python, let us not use the empty string to signify "no string". Theoretically, a crazy command line tool could have an empty-string optional parameter.

--
To view, visit http://gerrit.ovirt.org/2797
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2faa261a3c44cf84af14102bdf6479287435793b
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>


More information about the vdsm-patches mailing list