Change in vdsm[master]: Support unicode args in betterPopen

danken at redhat.com danken at redhat.com
Thu May 17 18:32:14 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Support unicode args in betterPopen
......................................................................


Patch Set 2: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/betterPopen/createprocess.c
Line 145:                          Py_FileSystemDefaultEncoding,
FileSystem? What's to Popen and to file systems?

yeah, I know this is not your fault, but Guido's.

--
To view, visit http://gerrit.ovirt.org/4414
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I194e75bfca30bcbc6d7fb0f2a24b30eb6162cddb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Wenchao Xia <xiawenc at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list