Change in vdsm[master]: Automatic reconnection to the Storage Pool

abaron at redhat.com abaron at redhat.com
Thu May 17 17:25:39 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: Automatic reconnection to the Storage Pool
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 321:                     self._connectStoragePool(spUUID, None, None, None, None)
Why are we passing None here? we should not be deleting the file to begin with (unless disconnectStoragePool is sent) and then use the correct values?

--
To view, visit http://gerrit.ovirt.org/4516
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I682a12deff90dd78bb31b7368c003796ed241cd9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list