Change in vdsm[master]: tests: add netinfo test for invalid nic name

ilvovsky at redhat.com ilvovsky at redhat.com
Thu May 17 07:13:43 UTC 2012


Igor Lvovsky has posted comments on this change.

Change subject: tests: add netinfo test for invalid nic name
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

Please tick verify flag for all your patches, if you verified it of course

....................................................
File tests/netinfoTests.py
Line 42:         self.assertTrue(s == 0)
it should be assertEqual, it gives more info in failures

--
To view, visit http://gerrit.ovirt.org/4322
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27e8c937495370d40a50e919a34d2a9173b03d60
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>


More information about the vdsm-patches mailing list