Change in vdsm[master]: tests: add netinfo test for speed() function

danken at redhat.com danken at redhat.com
Wed May 16 19:22:29 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: tests: add netinfo test for speed() function
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File tests/netinfoTests.py
Line 47:             ethtool_speeds = {10, 100, 1000, 2500, 10000}
would you mind using a syntax that works in python 2.4, too? (set(foo, bar).) I keep el6 in mind.

oh, and CONSTANTS are better written in caps, and defined out of the loop.

(yeah, yeah, caring about performance in short test is silly, I know)

--
To view, visit http://gerrit.ovirt.org/4323
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bf6404df05f09e984aef2f9c9264c9589d2b27e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>


More information about the vdsm-patches mailing list