Change in vdsm[master]: Tunnel errors from child to parent in betterPopen

danken at redhat.com danken at redhat.com
Wed May 16 18:12:28 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Tunnel errors from child to parent in betterPopen
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

-1 for visibility

....................................................
File vdsm/betterPopen/createprocess.c
Line 230:         close(errnofd[0]);
do we care about close() failing? (can it even happen for a pipe?)

--
To view, visit http://gerrit.ovirt.org/4413
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d4a132317e9cf0843671460a0876f615760731d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Wenchao Xia <xiawenc at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list