Change in vdsm[master]: configNetwork: remove skipLibvirt flag

danken at redhat.com danken at redhat.com
Wed May 16 11:41:34 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: configNetwork: remove skipLibvirt flag
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(2 inline comments)

I'm still confused. How your change solves the problem? It includes more than simple removal of skipLibvirt. I very much prefer that you re-write the commit message, and split this patch, if needed.

....................................................
File vdsm/configNetwork.py
Line 322:         self._removeFile(self.NET_CONF_PREF + bridge)
I do not know why this check was here in the first place, but why are you moving it now?

Line 655:     if netName not in conn.listNetworks():
that's not good enough, since the network may be defined (but unactive), or defined wrongly (bridged/bridgeless).

why are you including this change in this commit?

--
To view, visit http://gerrit.ovirt.org/4342
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie98ba38da64e34aedfd88b11880929ee4d99d0d6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list