Change in vdsm[master]: BZ#806625: validate vdsmcert against cacert

danken at redhat.com danken at redhat.com
Wed May 16 11:28:17 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#806625: validate vdsmcert against cacert
......................................................................


Patch Set 6: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/vdsmd.init.in
Line 245:     ret="$("${OPENSSL_CMD}" verify -CAfile "${PATH_CERT}"/cacert.pem \
too many quotes. are you sure you are happy with the value of $ret?

I think you should not quote "${OPENSSL_CMD}" within the "$(" quotes.

--
To view, visit http://gerrit.ovirt.org/4345
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I66fa4b502f4d78dae362cbdcb76b964e360fd119
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>


More information about the vdsm-patches mailing list