Change in vdsm[master]: tests: Add functional tests

ewoud at kohlvanwijngaarden.nl ewoud at kohlvanwijngaarden.nl
Wed May 16 10:13:24 UTC 2012


Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: tests: Add functional tests
......................................................................


Patch Set 1: (4 inline comments)

I think that in general it looks good, relative minor comments inline.

....................................................
File tests/functional/restTests.py
Line 44:         print e.read()
Can the print be replaced by logging or something else?

Line 50:     def assertHTTPError(self, code, fn, *args):
I'm not sure if the fn and args is that clear. How about just fn and lambdas in the actual tests?

Line 74:         self.assertHTTPError(404, request, "/api/doesnotexist")
This would become:

 self.assertHTTPError(404, lambda: request("/api/doesnotexist"))

Line 80:         self.assertHTTPError(405, request, "/api", 'json', 'data')
And this:

 self.assertHTTPError(405, lambda: request("/api", 'json', 'data'))

--
To view, visit http://gerrit.ovirt.org/4452
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id33dfabd7c67379351256aad8e09ad0a36e46246
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Wenchao Xia <xiawenc at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list