Change in vdsm[master]: Add a function wrapper to vdsm-tool for /etc/inid.d/function...

wenyi at linux.vnet.ibm.com wenyi at linux.vnet.ibm.com
Wed May 16 00:57:43 UTC 2012


Wenyi Gao has posted comments on this change.

Change subject: Add a function wrapper to vdsm-tool for /etc/inid.d/functions
......................................................................


Patch Set 1: (1 inline comment)

The initial motivation is that functions in the /etc/init.d/functions can be called in python code conveniently. Also some useful functions such as pidof,daemon and so on can be available via vdsm-tool. I am not sure if the motivation can make sense. 

Federico, could you clarify which function should be exposed to vdsm-tool? Thanks.

....................................................
File vdsm-tool/function.py
Line 19: 
Actually the file is already in the PEP8_WHITELIST since the directory "vdsm-tool" has been put in PEP8_WHITELIST.

--
To view, visit http://gerrit.ovirt.org/4419
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b9f9ba30515356b8bccfebdbab029c951ffa9b0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <wenyi at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list