Change in vdsm[master]: additional capsTests

ghammer at redhat.com ghammer at redhat.com
Tue May 15 14:01:53 UTC 2012


Gal Hammer has posted comments on this change.

Change subject: additional capsTests
......................................................................


Patch Set 2: (2 inline comments)

Added some inline comments.

....................................................
Commit Message
Line 2: Author:     y kaplan <ykaplan at redhat.com>
Please set your git's global config to your full name.

....................................................
File tests/capsTests.py
Line 66:         expectedRes = "wlan0"
You should use a loop rather than duplicate the code.

values = { "10.201.129.37": "wlan0", "192.168.122.90": "virbr0" }
for ip, name in values:
    self.assertEqual(name, caps._getIfaceByIP(ip, "route_info.out"))

--
To view, visit http://gerrit.ovirt.org/4185
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c8cbf4c5b7801b2887a84c8c3b7a503f1a995f1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>


More information about the vdsm-patches mailing list