Change in vdsm[master]: make compression type configurable, support gzip and xz

shaohef at linux.vnet.ibm.com shaohef at linux.vnet.ibm.com
Mon May 14 15:39:02 UTC 2012


ShaoHe Feng has posted comments on this change.

Change subject: make compression type configurable, support gzip and xz
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File configure.ac
Line 42: AC_PATH_PROG([XZ], [xz])
yes,  the logrotate compress type are same on build machine and the target machine by default.
Actually, if distribution was compressed by gzip, and logrotate configure compress type xz with the '--with-xz', the target machine should support both gzip and xz.tha is not we want.
So I think the logrotate compress type and distribution compress type should be configured same, and should be both configured by argument ike '--with-xz, --with-gzip'

--
To view, visit http://gerrit.ovirt.org/4174
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d88e9d40aefc87564c9c7e23f0d28aaad867aca
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list