Change in vdsm[master]: remove stale libvirtNet before creating a new net with same ...

danken at redhat.com danken at redhat.com
Mon May 14 14:25:26 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: remove stale libvirtNet before creating a new net with same name
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File vdsm/configNetwork.py
Line 662:     removeLibvirtNetwork(network, log=False)
I do not see a problem here. If we report that network as existing, we should not allow creating it.

Line 676:             logging.debug('failed to remove libvirt network ' + netName,
Done

--
To view, visit http://gerrit.ovirt.org/4370
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c25064ece089b0b5cdbad3c8789ec964c7b8752
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Avi Tal <atal at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list