Change in vdsm[master]: hook: balloon - Enable the virtio balloon

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Mon May 14 08:59:38 UTC 2012


Mark Wu has posted comments on this change.

Change subject: hook: balloon - Enable the virtio balloon
......................................................................


Patch Set 1: No score

(1 inline comment)

I still think we need a flag for it and hope to get opinions from other guys.

....................................................
File vdsm_hooks/balloon/before_vm_start.py
Line 10: 
I still think that we need a flag for it.  If we don't want to bring impact to the existing VMs, we should have a switch to disable the hook. Let's say I have several VMs running on a host. After upgrading vdsm containing this hook, the underlying device address could change. Actually, I can't figure out what problems it will cause. But if we do have concern about it, then we should have option to avoid it.

--
To view, visit http://gerrit.ovirt.org/4316
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idc7d533268aff536179045db06b81e17c5fae3db
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list