Change in vdsm[master]: libvirtvm.py: Extend controller support to allow configuring...

oourfali at redhat.com oourfali at redhat.com
Sun May 13 13:08:05 UTC 2012


Oved Ourfali has posted comments on this change.

Change subject: libvirtvm.py: Extend controller support to allow configuring USB controllers
......................................................................


Patch Set 3: (2 inline comments)

....................................................
File vdsm/libvirtvm.py
Line 864:         doc = xml.dom.minidom.Document()
Remove this line, as doc isn't used in this function.

Line 866:                                   ['index', 'model', 'master', 'address'])
Will we need the master and address, now that it is part of libvirt's responsibility?

--
To view, visit http://gerrit.ovirt.org/4095
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If4fd6bed73cfa67fd6b29d3c352aebc7c25cff5f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hans De Goede <hdegoede at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Hans De Goede <hdegoede at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>


More information about the vdsm-patches mailing list