Change in vdsm[master]: promisc: bug fixes

danken at redhat.com danken at redhat.com
Sun May 13 12:43:25 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: promisc: bug fixes
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File vdsm/libvirtvm.py
Line 1243:             if hasattr(nic, 'promisc') and utils.tobool(nic.promisc):
My job is to be annoying so that vdsm code looks better!

which exception is thrown by utils.tobool(getattr(nic, 'promisc', False)) ?

Line 2009:         #unsetting mirror network will clear both mirroring (on the same network).
why is this "too late"? the only thing that changes is the call to before_vm_destroy hook. or am I missing something?

--
To view, visit http://gerrit.ovirt.org/4359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6848b39e01997ff1c6769e3de9f60ba083647d3b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>


More information about the vdsm-patches mailing list