Change in vdsm[master]: promisc: bug fixes

danken at redhat.com danken at redhat.com
Sun May 13 09:19:47 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: promisc: bug fixes
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

thanks, minor comment though.

....................................................
File vdsm/libvirtvm.py
Line 1243:             if hasattr(nic, 'promisc') and utils.tobool(nic.promisc):
how about

 utils.tobool(getattr(nic, 'promisc', False))

--
To view, visit http://gerrit.ovirt.org/4359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6848b39e01997ff1c6769e3de9f60ba083647d3b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list