Change in vdsm[master]: Implement Popen without forking back to python

danken at redhat.com danken at redhat.com
Fri May 11 11:13:16 UTC 2012


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Implement Popen without forking back to python
......................................................................


Implement Popen without forking back to python

Python's implementation of Popen forks back to python before execing.
Forking a python proc is a very complex and volatile process and we
already have hacks to try and avoid some of the bugs involved with it.

This is a simpler method of execing that doesn't go back to python after
forking. This allows for faster safer exec.

Should solve bugs involving with GIL\GC\Logging deadlocks related to the
python implementation.

This also makes means that python-devel and gcc are needed for testing
as the extension needs to be compiled to be tested.

Change-Id: Ief4ae42eb57551d7f5893bf562da451a9c98f219
Signed-off-by: Saggi Mizrahi <smizrahi at redhat.com>
---
M configure.ac
M tests/Makefile.am
A tests/betterPopenTests.py
M tests/testrunner.py
M vdsm.spec.in
M vdsm/Makefile.am
A vdsm/betterPopen/.gitignore
A vdsm/betterPopen/Makefile.am
A vdsm/betterPopen/__init__.py
A vdsm/betterPopen/createprocess.c
A vdsm/betterPopen/setup.py
M vdsm/storage/misc.py
12 files changed, 479 insertions(+), 8 deletions(-)

Approvals:
  Ayal Baron: Looks good to me, but someone else must approve
  Wenchao Xia: Verified; Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/3944
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ief4ae42eb57551d7f5893bf562da451a9c98f219
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Wenchao Xia <xiawenc at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list