Change in vdsm[master]: Get network address to showNetwork

danken at redhat.com danken at redhat.com
Fri May 11 08:44:48 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Get network address to showNetwork
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/configNetwork.py
Line 708:         ipaddr = netdict['addr']
why is this specific for bridged? bridgeless networks may have ipaddress, too (actually the common place is that they do, while bridged do do)

--
To view, visit http://gerrit.ovirt.org/4326
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I791adbb9321d097fb609f0328e25d6d4f1865696
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <lilei at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Lei Li <lilei at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list